-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swamped by proto DeprecationWarnings #4737
Comments
I think this engine proto code is autogenerated by google api core tooling (gapic). @wcourtney, can we update gapic to get a newer proto version? |
It looks like there was a related issue in the common python protos library: googleapis/python-api-common-protos#23 It looks like they filtered these warnings as a short-term solution: microsoft/Qcodes#2598 They also added a fix that should resolve this if we re-build the proto set. IIRC, there were some manual tweaks to the generated protos that we'll need to identify and resolve. Fixing this import process seems like a good task for our new |
This looks like a duplicate of a long-standing issue in Cirq: #4161. In short: the warnings are due to compiling protos with an old version of Current workarounds include:
|
the filters in setup.cfg would satisfy me if they work |
This is no longer blocked by TFQ (and hasn't been for a while) it is entirely a matter of regenerating v1alpha1 using the internal gapic builds we have and then opening a PR with those changes. protoc considerations for TFQ are no longer an issue. |
Re-opening as this was never fixed for me by the linked PR. Would appreciate any further investigation or assistance
|
@mpharrigan, we updated the generated code in #5139 so the file referenced in the warnings no longer exists:
Could you try again to see if that has fixed these warnings? The new generated code uses the |
Running tests locally I no longer see any of these warnings related to protos, so going to close this. @mpharrigan, please confirm when you get a chance and we can always reopen if needed. |
Rules were verified as non-matching in all unit tests. Clean up after #4737 which does not bite anymore.
When running tests, warning and deprecation warnings can give a heads up on things that need to change in the near future, especially given Cirq's deprecation cycles. And if there's a test failure, one would like to see the details without having to develop carpal tunnel in the scroll-finger. We're currently overwhelmed by deprecation warnings from protos
The text was updated successfully, but these errors were encountered: