Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in check/pylint #3716

Closed
95-martin-orion opened this issue Jan 28, 2021 · 5 comments
Closed

Inconsistency in check/pylint #3716

95-martin-orion opened this issue Jan 28, 2021 · 5 comments
Labels
area/ci area/pylint kind/health For CI/testing/release process/refactoring/technical debt items

Comments

@95-martin-orion
Copy link
Collaborator

Description of the issue

PR #3698 hit the following pylint errors:

************* Module cirq.study.sweepable
cirq/study/sweepable.py:17:0: W0611: Unused Dict imported from typing (unused-import)
************* Module cirq.optimizers.align_right
cirq/optimizers/align_right.py:17:0: W0611: Unused ops imported from cirq (unused-import)
************* Module cirq.optimizers.align_left
cirq/optimizers/align_left.py:17:0: W0611: Unused ops imported from cirq (unused-import)

These files were not modified in this PR; as far as I can tell, the issues above were introduced in #3643 and #3644. Strangely, those PRs did not get flagged by the pylint checker.

I have confirmed that all three PRs listed here used pylint-2.6.0 in their checks.

How to reproduce the issue

Unclear. It seems like check/pylint behaves inconsistently in PR tests; we should double-check that it's set up correctly.

Cirq version
v0.10.0-dev

@95-martin-orion 95-martin-orion added the kind/bug-report Something doesn't seem to work. label Jan 28, 2021
@95-martin-orion 95-martin-orion changed the title inconsistency check/pylint Inconsistency in check/pylint Jan 28, 2021
@95-martin-orion
Copy link
Collaborator Author

I was not able to reproduce this locally on branch 95-martin-orion:cirq-expects-values, despite both issues being present on inspection.

@balopat balopat added area/ci area/pylint kind/health For CI/testing/release process/refactoring/technical debt items and removed kind/bug-report Something doesn't seem to work. labels Jan 28, 2021
@balopat
Copy link
Contributor

balopat commented Jan 28, 2021

On My Mac, I see only the Unused Dict imported from typing (unused-import) error, the other too doesn't show up. It's odd that pylint is inconsistent between environments.

@tonybruguier
Copy link
Contributor

I can find some issues locally. I'm using ubuntu and it happens to be an ec2 instance, so I could share access with someone if they want to repro (or run some commands to help track things).

@vtomole
Copy link
Collaborator

vtomole commented Oct 19, 2021

Some pylint errors on my local machine from the main branch

Description of the issue

(venv8) (base) vtomole@vtomole:~/Cirq$ ./check/pylint
************* Module cirq.ops.pauli_string_test
cirq-core/cirq/ops/pauli_string_test.py:1302:23: E1121: Too many positional arguments for method call (too-many-function-args)
************* Module cirq.ops.gate_operation
cirq-core/cirq/ops/gate_operation.py:199:19: E1102: getter is not callable (not-callable)
************* Module cirq_ionq.service
cirq-ionq/cirq_ionq/service.py:115:19: E1123: Unexpected keyword argument 'seed' in method call (unexpected-keyword-arg)

Cirq version

(venv8) (base) vtomole@vtomole:~/Cirq$ pylint --version
pylint 2.6.0
astroid 2.5
Python 3.8.5 (default, Sep  4 2020, 07:30:14) 
[GCC 7.3.0]

@95-martin-orion
Copy link
Collaborator Author

Marking resolved since I can't remember seeing this since the two PRs above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/pylint kind/health For CI/testing/release process/refactoring/technical debt items
Projects
None yet
Development

No branches or pull requests

4 participants