Refactor TinyMCE hook functions in common #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwave
added a commit
to qwave/qtranslate-xt
that referenced
this pull request
Apr 14, 2021
* [Yoast] Add front filters schema and breadcumbs (qtranslate#947) * Add Bangla localization files (qtranslate#960) * Fix async events with jQuery3 (qtranslate#946) * Anticipate qtx init before TinyMCEinit (qtranslate#946) * Fix deprecated tinymce.editors (qtranslate#946) * Remove ready handler from common (qtranslate#946) With jQuery3, ready and load can be fired asynchronously. We cannot assume ready is fired before load. Since qtx is also initialized in load, no need for ready anymore. * Refactor TinyMCE hook functions in common (qtranslate#978) * Add permalink info for pre-path mode (qtranslate#821) * Release 3.9.3 * Fix async qtx loading in ACF (qtranslate#988) * Bundle Javascript with Webpack and Babel (qtranslate#990) See instructions in the Pull Request. Reactivate plugin or save settings to update the new paths in admin config. * Minor webpack cleanup * Bundle ACF with Webpack (qtranslate#992) Regroup all sources into a single bundle dist/modules/acf.js. Move and rename source files. * Split common.js and rename to main (qtranslate#994) * Split common.js into multiple core source files * Rename common.js to main.js (entry and output) * Rename qtranslate-admin-common PHP to qtranslate-admin-main * qTranslateX class definition no longer exposed * Refactor js var with ES6 const and let (qtranslate#996) * Fix text variable not defined (qtranslate#995) * Refactor ACF js with ES6 const let (qtranslate#997) * Refactor jQuery wrappers with local alias (qtranslate#998) * Disambiguate and rename js variables (qtranslate#1001) * Define js constants for URL mode * Remove unused js functions * Minor js cleanup * Complete js vars renaming * Update dist js * Delete deprecated functions in 3.7.3 * Fix qtx and repeaterFieldRemove in ACF JS (qtranslate#1006) * Fix undefined use_block_editor_for_post (qtranslate#1004) Co-authored-by: HerrVigg <herrvigg@gmail.com> Co-authored-by: Lenin <doctortomorrow@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatten the nested declarations in
addContentHooksTinyMCEto make the code more readable:setEditorHooksup as a private functionsetTinyMceInitbut keep its code inaddContentHooksTinyMCE()(it was the only function run with no args)loadTinyMceHooksup as a public function and rename it asloadAdditionalTinyMceHooksloadAdditionalTinyMceHooksonloadinstead of passing viaaddContentHooksTinyMCE('load')The code run is supposed to remain exactly the same.