Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress files into a single coverage.zip and update upload logic accordingly #1528

Merged
merged 9 commits into from
Feb 27, 2025

Conversation

noahd1
Copy link
Member

@noahd1 noahd1 commented Feb 25, 2025

Instead of uploading 4 separate files for coverage uploads, this uploads a single zip file containing the 4 files.

This cannot be merged until a server side component which knows how to read the single zip file is merged.

@noahd1 noahd1 requested a review from brynary February 25, 2025 05:46
Copy link
Contributor

qltysh bot commented Feb 25, 2025

Diff Coverage: The code coverage on the diff in this pull request is 89.1%.

Total Coverage: This PR will increase coverage by 1.32%.

File Coverage Changes
Path File Coverage Δ Indirect
qlty-cli/src/lib.rs 6.8
qlty-check/src/tool.rs 0.1
qlty-cli/src/ui/fixes.rs 1.2
qlty-check/src/cache.rs 70.1
qlty-cloud/src/format.rs -35.7
qlty-cli/src/ui/level.rs 11.1
qlty-check/src/executor/invocation_result.rs 22.7
qlty-cli/src/arguments.rs 0.9
qlty-check/src/planner/driver.rs 0.5
qlty-check/src/executor.rs 0.6
qlty-analysis/src/cache.rs 4.5
qlty-check/src/planner/source_extractor.rs 0.8
qlty-cli/src/commands/fmt.rs 62.7
qlty-cloud/src/format/gz.rs -100.0
qlty-cli/src/initializer/scanner.rs 0.1
qlty-check/src/planner/plan.rs 1.4
qlty-check/src/tool/tool_builder.rs 16.4
qlty-check/src/tool/download.rs 19.1
qlty-cli/src/ui/invocations.rs 3.1
qlty-check/src/planner/plugin.rs 2.3
qlty-check/src/issue_muter.rs 0.2
qlty-check/src/tool/python.rs 11.4
qlty-cli/src/ui/unformatted.rs 21.6
qlty-cloud/src/export/coverage.rs 23.6
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@noahd1 noahd1 changed the title Compress files into a single coverage.zip and update upload logic accordingly Compress files into a single coverage.zip and update upload logic accordingly [WAIT TO MERGE] Feb 25, 2025
Copy link
Contributor

qltysh bot commented Feb 26, 2025

All good ✅

Copy link
Member

@brynary brynary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification!

@noahd1 noahd1 changed the title Compress files into a single coverage.zip and update upload logic accordingly [WAIT TO MERGE] Compress files into a single coverage.zip and update upload logic accordingly Feb 27, 2025
@noahd1 noahd1 merged commit 6373a18 into main Feb 27, 2025
8 checks passed
@noahd1 noahd1 deleted the nd-upload-single-coverage-file branch February 27, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants