Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deprecated sources warning to error #1515

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

marschattha
Copy link
Member

No description provided.

@marschattha marschattha requested a review from brynary February 20, 2025 18:17
Copy link
Contributor

qltysh bot commented Feb 20, 2025

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will increase coverage by 0.03%.

File Coverage Changes
Path File Coverage Δ Indirect
qlty-cloud/src/auth/auth_flow.rs -0.5
qlty-config/src/config.rs 0.4
qlty-check/src/tool/command_builder.rs 2.6
qlty-check/src/tool/ruby/sys/macos.rs 2.6
qlty-check/src/tool/download.rs 0.7
qlty-check/src/executor/driver.rs -0.9
qlty-check/src/tool/ruby/sys/linux.rs -1.3
qlty-analysis/src/workspace_entries/target_mode.rs -8.3
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

1 similar comment
Copy link
Contributor

qltysh bot commented Feb 20, 2025

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will increase coverage by 0.03%.

File Coverage Changes
Path File Coverage Δ Indirect
qlty-cloud/src/auth/auth_flow.rs -0.5
qlty-config/src/config.rs 0.4
qlty-check/src/tool/command_builder.rs 2.6
qlty-check/src/tool/ruby/sys/macos.rs 2.6
qlty-check/src/tool/download.rs 0.7
qlty-check/src/executor/driver.rs -0.9
qlty-check/src/tool/ruby/sys/linux.rs -1.3
qlty-analysis/src/workspace_entries/target_mode.rs -8.3
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Member

@brynary brynary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should get assistance from support to make a best effort attempt to notify affected customers before we deploy this.

@brynary brynary merged commit 754aaac into main Feb 21, 2025
11 checks passed
@brynary brynary deleted the ma/deprecated_sources_throw_error_now branch February 21, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants