Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore import statements (Java) and using directives (C#) when calculating duplication #1413

Merged
merged 3 commits into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
config_version = "0"
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package foobar;

import java.io.*;
import java.util.*;
import java.net.*;
import java.nio.file.*;
import java.text.*;
import java.lang.*;
import java.nio.*;
import java.util.concurrent.*;
import java.util.concurrent.atomic.*;
import zjava.nio.*;
import zjava.util.concurrent.*;
import zjava.util.concurrent.atomic.*;
import ajava.nio.*;
import ajava.util.concurrent.*;
import ajava.util.concurrent.atomic.*;
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package foobar;

import java.io.*;
import java.util.*;
import java.net.*;
import java.nio.file.*;
import java.text.*;
import java.lang.*;
import java.nio.*;
import java.util.concurrent.*;
import java.util.concurrent.atomic.*;
import zjava.nio.*;
import zjava.util.concurrent.*;
import zjava.util.concurrent.atomic.*;
import ajava.nio.*;
import ajava.util.concurrent.*;
import ajava.util.concurrent.atomic.*;
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
using System.IO;
using System.Diagnostics;
using System.Globalization;
using System.Net;
using System.Net.Http;
using AFoo.Bar;
using BNoo.Net;
using BNoo.Net.Http;
using BNoo.Net.Http.Client;
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
using System.IO;
using System.Diagnostics;
using System.Globalization;
using System.Net;
using System.Net.Http;
using Foo.Bar;
using Noo.Net;
using Noo.Net.Http;
using Noo.Net.Http.Client;
4 changes: 4 additions & 0 deletions qlty-cli/tests/cmd/smells/ignore_duplication_patterns.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[0/3] [..]Analyzing all targets... [..]s
[1/3] [..]Checking structure of 4 files... [..]s
[2/3] [..]Looking for duplication across 4 files... [..]s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would delete this file, because the snapshot testing framework will not match against stderr if there is no file. This will make the test less brittle

[3/3] [..]Reporting...[..]
2 changes: 2 additions & 0 deletions qlty-cli/tests/cmd/smells/ignore_duplication_patterns.stdout
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@

[]
3 changes: 3 additions & 0 deletions qlty-cli/tests/cmd/smells/ignore_duplication_patterns.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
args = ["smells", "--all", "--no-snippets", "--json"]
bin.name = "qlty"
status.code = 0
2 changes: 2 additions & 0 deletions qlty-config/default.toml
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,7 @@ smells.duplication.nodes_threshold = 50

[language.java]
globs = ["*.java"]
smells.duplication.filter_patterns = ["(import_declaration _)"]

[language.javascript]
globs = ["*.js", "*.mjs", "*.cjs", "*.jsx", "**/Jakefile"]
Expand Down Expand Up @@ -438,6 +439,7 @@ globs = ["*.tsx", "*.mtsx", "*.ctsx"]

[language.csharp]
globs = ["*.cs"]
smells.duplication.filter_patterns = ["(using_directive _)"]

[smells.boolean_logic]
threshold = 4
Expand Down
Loading