Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set token via qlty auth login --token <TOKEN> #1407

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

lsegal
Copy link
Member

@lsegal lsegal commented Jan 7, 2025

If "" or "-" are provided, token is read from STDIN

If "" or "-" are provided, token is read from STDIN
@lsegal lsegal self-assigned this Jan 7, 2025
@lsegal lsegal requested a review from a team January 7, 2025 02:07
Copy link
Member

@brynary brynary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple small comments but overall LGTM!


#[derive(Args, Debug)]
pub struct Login {}
pub struct Login {
/// Provide a CLI token manually or use "-" to read from standard input (see https://qlty.sh/user/settings/cli)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This help string may be a bit long and cause wrapping. I generally try to keep these to a length of ~60-70 max

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wrapping is handled by clap:

Options:
      --token <TOKEN>     Provide a CLI token manually or use "-" to read from standard input (see
                          https://qlty.sh/user/settings/cli)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah lovely, didn't realize that. Thanks

@lsegal lsegal merged commit 3a6d2d2 into ls/refactor-auth-token Jan 7, 2025
7 of 8 checks passed
@lsegal lsegal deleted the ls/auth-cli-token-set branch January 7, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants