Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skip-missing-files flag #45

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Add skip-missing-files flag #45

merged 2 commits into from
Feb 25, 2025

Conversation

marschattha
Copy link
Member

No description provided.

@marschattha marschattha requested review from brynary, a team and lsegal February 25, 2025 22:31
@lsegal
Copy link
Member

lsegal commented Feb 25, 2025

I don't understand the CI error but the change itself looks fine.

@marschattha
Copy link
Member Author

We build a separate dist file, gotta run npm run package to build that and it compares if the updates are included in that.

@marschattha
Copy link
Member Author

Weird err on qlty check though

@marschattha marschattha merged commit 595c946 into main Feb 25, 2025
1 of 2 checks passed
@dejan-lukic
Copy link

dejan-lukic commented Feb 25, 2025 •
edited
Loading

Hi @marschattha, this one seems to be causing some issues:

Screenshot 2025-02-26 at 10 25 08 AM

probably need to add it to action.yml too?

@piranna
Copy link

piranna commented Feb 27, 2025

probably need to add it to action.yml too?

Yes, if not there, it's not possible to enable the flag in the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsegal lsegal lsegal approved these changes

@brynary brynary Awaiting requested review from brynary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marschattha @lsegal @dejan-lukic @piranna