Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #1471 , the issue where the
watch
flag in thebuild
command does not pick up file changes. This also includes theserve
command since it's using the same underlying code.The root cause of this issue seem to be that the
rollup-plugin-sourcemaps
plugin has not updated to support Rollup v4, which has some changes to it's Plugin API (https://rollupjs.org/migration/#changes-to-the-plugin-api).From the tests I've done Babel source maps works fine as a replacement.
There still seem to be some issue related to
@rollup/plugin-commonjs
where it can crash the build/watch process. But I'm not able to reproduce that consistently across the different nebula.js projects I've tested with. But this PR rollup/plugins#1639 seem to be the culprint of that crash at least. So using v26.0.3 should still work in those projects.Requirements checklist
yarn spec
When build and tests have passed: