Bugfix: missing extra in mitigated tomography analysis #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coruscating
reviewed
Dec 19, 2023
|
Thanks, updated in 82b4424 |
nkanazawa1989
added a commit
to nkanazawa1989/qiskit-experiments
that referenced
this pull request
Jan 17, 2024
…ity#1344) ### Summary qiskit-community#1133 introduce a bug in `MitigatedTomographyAnalysis` that accidentally drops extra analysis metadata. This PR fixes the bug. ### Details and comments In the new data storage implementation with dataframe, `ExperimentData.analysis_results` returns a copy of the protected dataframe and mutating the returned object doesn't update the source. This PR introduces new option to `TomographyAnalysis` to inject extra metadata. <img width="993" alt="screenshot" src="https://github.com/Qiskit-Extensions/qiskit-experiments/assets/39517270/d8674af1-78ad-4870-bfea-d441f9dfd1e8"> (edit) note that reno is not necessary because 1133 is not released yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#1133 introduce a bug in
MitigatedTomographyAnalysisthat accidentally drops extra analysis metadata. This PR fixes the bug.Details and comments
In the new data storage implementation with dataframe,
ExperimentData.analysis_resultsreturns a copy of the protected dataframe and mutating the returned object doesn't update the source. This PR introduces new option toTomographyAnalysisto inject extra metadata.(edit) note that reno is not necessary because 1133 is not released yet.