Bugfix in ExperimentData's handling of metadata save #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coruscating
reviewed
Jul 19, 2023
releasenotes/notes/experiment_data_metadata_save_fix-912b7180a28cfb03.yaml
Outdated
Show resolved
Hide resolved
coruscating
added
backport stable potential
…28cfb03.yaml Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>
coruscating
reviewed
Jul 20, 2023
coruscating
reviewed
Jul 20, 2023
coruscating
reviewed
Jul 20, 2023
Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>
mergify bot
pushed a commit
that referenced
this pull request
Jul 20, 2023
### Summary This PR fixes a bug resulting in experiment data saving fails due to large payloads. ### Details and comments Since the `metadata` field of `ExperimentData` can grow tremendously large, resulting in a save failure due to the large payload. we have added has the ability to save the metadata as an artifact file. However, a small bug prevented this from triggering. This PR fixes the bug and adds a relevant test. --------- Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com> (cherry picked from commit 970b376) # Conflicts: # requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug resulting in experiment data saving fails due to large payloads.
Details and comments
Since the
metadatafield ofExperimentDatacan grow tremendously large, resulting in a save failure due to the large payload. we have added has the ability to save the metadata as an artifact file. However, a small bug prevented this from triggering. This PR fixes the bug and adds a relevant test.