-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to Qiskit Primitives #115
Migration to Qiskit Primitives #115
Conversation
@IceKhan13 I have noticed something that might be unrelated to this issue. There is a problem in test_adaper.py to be specific function
For more info, you can see here |
I have also reverted from qiskit_algoritm to qiskit.algorithm. A new issue should be opened for this migration.
reformatting tutorial 3
Note I had to comment out XXMinusYYGate(Parameter("ϴ")), and XXPlusYYGate(Parameter("ϴ")) from the standard_gates due to an unrelated bug which causes the test to fail.
The error with
Note this is unrelated to this PR, it something I stumbled upon. |
Hey @robotastray ! Thank for this PR! hmm, something is wrong with this gate specifically. You are right test failing in main branch too https://github.com/qiskit-community/qiskit-braket-provider/actions/runs/5768152751/job/15638813727 and only for python 3.10, but not for 3.7 🤔 Give me couple of days, I will try to figure out what is going on, so we can remove commented gates from this PR. As a heads-up PR looks great! :) |
@robotastray fixed failing tests in #118. Make sure to merge changes from main, uncomment tests and we can move with PR review! |
Hello @IceKhan13, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
Thank you @robotastray !
Summary
This PR aims to resolve issue #83.
Details and comments
File:
test_braket_backend.py
Function
test_vqe()
:used from
qiskit.algorithms.minimum_eigensolvers import VQE, VQEResult
(Note: "The old VQE class has been superseded by the qiskit.algorithms.minimum_eigensolvers.VQE class.")substituted
QuantumInstance
withBackendEstimator
used
estimator
as argument forVQE
substituted
qiskit.opflow
withqiskit.quantum_info
used
SparsePauliOp
to represent Pauli operatorsFile:
test_adapter.py
qiskit.opflow
withqiskit.quantum_info
SparsePauliOp
to represent Pauli operatorsFile:
test_braket_job.py
No changes
File:
test_braket_provider.py
No changes
File:
docs/tutorials/0_tutorial_qiskit-braket-provider_overview.ipynb
VQE
fromqiskit.algorithms.minimum_eigensolvers
QuantumInstance
withBackendEstimator
SparsePauiliOp
as alternative toqiskit.opflow
operatorsFile:
docs/tutorials/1_tutorial_vqe.ipynb
VQE
fromqiskit.algorithms.minimum_eigensolvers
QuantumInstance
withBackendEstimator
SparsePauiliOp
as alternative toqiskit.opflow
operatorsFile:
docs/tutorials/2_tutorial_hybrid_jobs_byoc.ipynb
! cat ./data/2_hybrid_jobs/job_script.py
which displayed the content of the newjob_script.py
File:
docs/tutorials/3_tutorial_minimum_eigen_optimizer.ipynb
QuantumInstance
withBackendSampler
COBYLA
to be used as optimiser forQAOA
QAOA
,NumPyMinimumEigensolver
from newqiskit.algorithms.minimum_eigensolvers
options={ "seed_simulator": algorithm_globals.random_seed, "seed_transpiler": algorithm_globals.random_seed, },
as options inBackendSampler()
File:
/data/2_hybrid_jobs/job_script.py
VQE
fromqiskit.algorithms.minimum_eigensolvers
QuantumInstance
withBackendEstimator
SparsePauiliOp
as alternative toqiskit.opflow
operators