Heatmap Plugin #93
Closed
Heatmap Plugin #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Hi Thank you. I made a few small tweaks - making gtiff default format and evaluating ok button after changing the line edit. Your work is now in QGIS Master branch as bc43fdd..03fd388 (I squashed your merge request into a single commit). Could you please provide a patch against doc/CONTRIBUTORS with your name so that you can be credited for your work? Thanks for the time & effort you have put into this! Regards Tim |
|
Hello, Here is the patch adding my name in the CONTRIBUTORS file. Thank you. Regards, |
|
Arunmozhi, There is no patch attached to the message. If you send a patch to the mailing list I can apply it for you. Nathan |
|
Just providing us your name & surname is enough otherwise.... Regards Tim |
yjacolin
pushed a commit
to yjacolin/QGIS
that referenced
this pull request
Oct 4, 2014
Marked up inline code in repo readme
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Tim,
I have taken into account all your points and has rewritten the entire thing from scratch. The heatmap is now generated using the GDAL drivers, the plugin has useful help content, follows 2 spaces convention and everything you mentioned in your feedback. Kindly take your time to review and tell me if there are any changes to be corrected.
I haven't included the logic in the analysis code, everything is in the plugin code itself. This can be changed if it is necessary later.
Regards,
Arunmozhi