Fix null ptr dereference in MiscExtension and AudiStore (#2387)

* Fix null ptr dereference in MiscExtension * Fix null ptr dereference in AudiStore
qdrvm · Mar 1, 2025 · 13a5631 · 13a5631
1 parent f258af6
commit 13a5631
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/core/authority_discovery/query/audi_store_impl.cpp b/core/authority_discovery/query/audi_store_impl.cpp
@@ -11,7 +11,8 @@
 namespace kagome::authority_discovery {
 
   AudiStoreImpl::AudiStoreImpl(std::shared_ptr<storage::SpacedStorage> storage)
-      : space_{storage->getSpace(storage::Space::kAudiPeers)} {
+      : space_{storage->getSpace(storage::Space::kAudiPeers)},
+        log_{log::createLogger("AudiStore", "authority_discovery")} {
     BOOST_ASSERT(space_ != nullptr);
   }
 

diff --git a/core/host_api/impl/misc_extension.cpp b/core/host_api/impl/misc_extension.cpp
@@ -23,10 +23,12 @@ namespace kagome::host_api {
       std::shared_ptr<const runtime::CoreApiFactory> core_factory)
       : hasher_{std::move(hasher)},
         memory_provider_{std::move(memory_provider)},
+        storage_provider_{std::move(storage_provider)},
         core_factory_{std::move(core_factory)},
         logger_{log::createLogger("MiscExtension", "misc_extension")} {
     BOOST_ASSERT(hasher_);
     BOOST_ASSERT(memory_provider_);
+    BOOST_ASSERT(storage_provider_);
   }
 
   runtime::WasmSpan MiscExtension::ext_misc_runtime_version_version_1(

diff --git a/test/core/host_api/misc_extension_test.cpp b/test/core/host_api/misc_extension_test.cpp
@@ -12,6 +12,7 @@
 #include "mock/core/runtime/core_api_factory_mock.hpp"
 #include "mock/core/runtime/core_mock.hpp"
 #include "mock/core/runtime/memory_provider_mock.hpp"
+#include "mock/core/runtime/trie_storage_provider_mock.hpp"
 #include "scale/scale.hpp"
 #include "testutil/literals.hpp"
 #include "testutil/prepare_loggers.hpp"
@@ -23,6 +24,7 @@ using kagome::host_api::MiscExtension;
 using kagome::runtime::CoreApiFactoryMock;
 using kagome::runtime::MemoryProviderMock;
 using kagome::runtime::TestMemory;
+using kagome::runtime::TrieStorageProviderMock;
 using scale::encode;
 using testing::_;
 using testing::Invoke;
@@ -58,11 +60,13 @@ TEST_F(MiscExtensionTest, CoreVersion) {
         return core;
       }));
 
+  auto storage_provider = std::make_shared<TrieStorageProviderMock>();
+
   kagome::host_api::MiscExtension m{
       42,
       std::make_shared<HasherMock>(),
       memory_provider,
-      nullptr,
+      storage_provider,
       core_factory,
   };
   ASSERT_EQ(memory[m.ext_misc_runtime_version_version_1(memory["test"_v])],