Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Send client version to server in headers #861

Merged
merged 7 commits into from
Dec 5, 2024
Merged

Conversation

tellet-q
Copy link
Contributor

@tellet-q tellet-q commented Dec 2, 2024

Use headers (User-Agent for http and user-agent for grpc) to pass client's version to server.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@tellet-q tellet-q requested review from generall and joein December 2, 2024 09:27
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 7b6a6a3
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/675051def722f3000887b109
😎 Deploy Preview https://deploy-preview-861--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tellet-q tellet-q requested a review from joein December 3, 2024 11:46
joein
joein previously approved these changes Dec 3, 2024
@joein joein dismissed their stale review December 3, 2024 13:15

python grpc library overrides user-agent with "grpc-python/1.68.0rc1 grpc-c/44.1.0 (osx; chttp2)"

@joein joein self-requested a review December 3, 2024 13:15
@tellet-q tellet-q merged commit ebc358c into dev Dec 5, 2024
14 checks passed
@tellet-q tellet-q deleted the version-to-server branch December 5, 2024 07:08
joein pushed a commit that referenced this pull request Jan 16, 2025
* new: Send client version in request's headers (http and gRpc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants