Fix sort sparse vectors #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
agourlay
reviewed
Jan 19, 2024
| @@ -401,7 +401,7 @@ def search( | |||
| scores = calculate_context_scores(query_vector, vectors[: len(self.payload)], distance) | |||
| elif isinstance(query_vector, SparseVector): | |||
| # sparse vector query must be sorted by indices for dot product to work with persisted vectors | |||
| sort(query_vector) | |||
| query_vector = sort_sparse_vector(query_vector) | |||
There was a problem hiding this comment.
That's embarrassing, I guess I thought this was a sort in place 😵💫
agourlay
reviewed
Jan 19, 2024
| if is_sorted(vector): | ||
| return vector | ||
|
|
||
| sorted_indices = np.argsort(vector.indices) | ||
| return SparseVector( | ||
| indices=vector.indices[sorted_indices], | ||
| values=vector.values[sorted_indices], | ||
| indices=[vector.indices[i] for i in sorted_indices], |
There was a problem hiding this comment.
vector.indices and vector.values are built-in python lists
This kind of lists does not support indexing by array of indices
To take elements from an array by several indices, this array should support such an operation (e.g. np.array)
generall
approved these changes
Jan 19, 2024
joein
added a commit
that referenced
this pull request
Jan 19, 2024
* fix: fix sparse vector sorting * fix: fix sparse vector sort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#439