New public sparse vector configuration #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
12 tasks
agourlay
commented
Dec 6, 2023
| @@ -1255,7 +1255,7 @@ def convert_sparse_index_config(cls, model: grpc.SparseIndexConfig) -> rest.Spar | |||
| full_scan_threshold=model.full_scan_threshold | |||
| if model.HasField("full_scan_threshold") | |||
| else None, | |||
| on_disk=model.on_disk if model.HasField("on_disk") else None, | |||
| index_type=model.on_disk if model.HasField("on_disk") else None, # TODO the types are incompatible for a conversion? | |||
There was a problem hiding this comment.
I have a problem here, the types do not align.
On one side an Optional and on the other side an enum.
There was a problem hiding this comment.
Because you need convert into SparseIndexParams. Andrey declined and reverted changes in grpc here qdrant/qdrant#3168, so that we have names mismatch
|
first green run, marking for review |
generall
approved these changes
Dec 6, 2023
joein
pushed a commit
that referenced
this pull request
Dec 7, 2023
* New public sparse vector configuration * regen * fix stubs * fix test * conversions * fix conversion * apply api changes --------- Co-authored-by: generall <andrey@vasnetsov.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qdrant/qdrant#3154