update interface and version for fastembed #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
generall
commented
Oct 16, 2023
generall
commented
- Allow iterators in fastembed
- Update to v0.1.1
- Allow parallel inference
joein
reviewed
Oct 16, 2023
| vector_name = self.get_vector_field_name() | ||
| for idx, meta, (doc, vector) in zip(ids, metadata, encoded_docs): | ||
| ids_accumulator.append(idx) | ||
| payload = {"document": doc, **meta} |
There was a problem hiding this comment.
if you get picky, here we can actually overwrite "document" if meta has such a field
There was a problem hiding this comment.
yes, I also don't like this, but we can't change it anymore
There was a problem hiding this comment.
somehow missed it in last release
joein
reviewed
Oct 16, 2023
| hnsw_config=hnsw_config, | ||
| ) | ||
| } | ||
|
|
||
| def add( |
There was a problem hiding this comment.
return type is not updated in the docstring
joein
reviewed
Oct 16, 2023
| collection_name=collection_name, | ||
| records=records, | ||
| wait=True, | ||
| parallel=parallel or 1, |
There was a problem hiding this comment.
don't we want to propagate batch_size here?
joein
approved these changes
Oct 16, 2023
generall
added a commit
that referenced
this pull request
Oct 16, 2023
* update interface and version for fastembed * fix types * fix types * regen async * use python 3.11 to check compatibility * fix docstring * regen async * propagate batch size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.