Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fastembed for pydantic 1.x #285

Merged
merged 4 commits into from
Sep 11, 2023
Merged

fix fastembed for pydantic 1.x #285

merged 4 commits into from
Sep 11, 2023

Conversation

generall
Copy link
Member

  • Fix type in _embed_documents - should always return List[float]
  • Fix query_embed usage
  • Use fastembed dependency as extras, so the version compatibility is enforced by qdrant client. Also, it should be installed as qdrant-client[fastembed]

@generall generall requested a review from NirantK September 10, 2023 22:30
@generall generall requested a review from joein September 11, 2023 12:53
@generall generall merged commit 8452f2a into dev Sep 11, 2023
joein pushed a commit that referenced this pull request Sep 11, 2023
* fix fastembed for pydantic 1.x

* add extras setup in readme

* move fastembed from group to extras

* lock
@generall generall deleted the more-tests-for-fastembed branch May 3, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants