disable forcing of http2 for cloud connections #258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to reproduce the problem, reported by our users some time ago, regarding random
errors in in consequent calls in FastAPI.
Here is a some fragment to reproduce:
Query with:
( full code to reproduce available at request)
the error is reproducible with raw httpx Client as well, so it is not some problem of the client wrapper.
Turns out the core reason is usage of http2 in out cloud connections. If http2 is disabled explicitly, no errors reproduced.
I do not remember why we turned it on in a first place, but it seems like everything is working fine with v1.1 as well.
@fabriziobonavita please confirm.
This PR disables automatic http2, but allows user to enable it with parameter.