Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of oml/vitb16-unicom and oml/vitb32-unicom #286

Closed
wants to merge 2 commits into from

Conversation

I8dNLo
Copy link
Contributor

@I8dNLo I8dNLo commented Jul 5, 2024

No description provided.

@I8dNLo I8dNLo requested review from joein and generall July 6, 2024 20:58
"sources": {
"hf": "AndrewOgn/vitb32_unicom",
},
"model_file": "vitb32_unicom.onnx",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we name the files model.onnx ? Looks to be some kind of a convention

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vit models usually named like this rather than vitb16

sentence-transformers/clip-ViT-B-32

@joein
Copy link
Member

joein commented Jul 9, 2024

looks good, the remaining part is to rename models, push to the qdrant repo and rebase the branch

@joein
Copy link
Member

joein commented Jul 10, 2024

closed in favour of #291

@joein joein closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants