-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sparse vectors support #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
I've changed the |
Also, here are results on my busy machine: $ bfb -n 10000 --dim 2048 --search --sparse-vectors --on-disk-index true
--- Search timings ---
Min search time: 0.000249218
Avg search time: 0.022734802924000017
p95 search time: 0.044381216
p99 search time: 0.046892587
Max search time: 0.073775338
--- Server timings ---
Min search time: 0.00008789
Avg search time: 0.022489696575899967
p95 search time: 0.044086216
p99 search time: 0.046608329
Max search time: 0.073426011
--- RPS ---
Min rps: 86.02060530603548
Avg rps: 88.08529494580816
p95 rps: 89.89534703227301
p99 rps: 90.0289776225274
Max rps: 1116.6270267271339
$ bfb -n 10000 --dim 2048 --search --sparse-vectors --on-disk-index false
--- Search timings ---
Min search time: 0.000220528
Avg search time: 0.02254625945380004
p95 search time: 0.044441273
p99 search time: 0.047454161
Max search time: 0.068276639
--- Server timings ---
Min search time: 0.000060349
Avg search time: 0.022295191263000034
p95 search time: 0.044145646
p99 search time: 0.047097525
Max search time: 0.067878882
--- RPS ---
Min rps: 86.89633905494993
Avg rps: 89.26247468255279
p95 rps: 93.62051455556441
p99 rps: 103.21010632830085
Max rps: 237.56436290017766 |
Small change: #21 |
fix: Display --sparse-vector SPARSITY in help to clarify the usage
timvisee
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for sparse vectors.
result from my busy laptop
Future work