-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added texdomain and portuguese files update #100
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one was intentional. It is translated by WordPress, since it is a string from the main installation. It goes to .pot file anyway, it does not hurt to have it there translated, but if there is no .po file for a language, it will be translated anyway from WordPress, if domain is not specified. In this case, it is important to keep translation the same as in WP, since otherwise a person may not recognize, which option is meant.
I know, we discussed a few similar cases, and I am not sure every time. It seems to me that it is better to have at least a few strings translated in the absence of .po, than nothing. It does not really make a difference to translator, since it gets to .pot file in any case. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that this was already on the main WordPress .po because it's a link that appeared translated within a sentence not translated. So, I've found it's origin and translated it like it is in the main .po.
Yes, I think that the .po must be 100%, of course if you use a lot of strings similar to main WordPress localization files qTranslate will appear at leas somehow translated, but in the end that is not what's intended.
In the end I think it's not worthy to you to try to use strings already translated in the main WordPress, to brain expensive :)
With or without textdomain, if a specific localization don't exist, qTranslate will get it from the main files, so there is no difference, please always include it.
Translators should of course make their work perfectly according to WordPress terms, rules and guidelines.
This reminds me of the Translation Guide that we've not completed yet :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said above, I've spotted that already existing translation because I was lucky.
I suggest that if you want to use a specific title of something already existing, like this Admin Color Scheme, maybe you can add a comment to it, strings like Plugin titles, trademarks or author names can sometimes be confused with strings to translate. In this particular case a comment to explain it's context is the best way to inform translators what to do with that particular string.