suggested changes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please check that I've made the correct replacement!
Please check that I've made the correct replacements
(otherwise _metadataObjForKey_ wouldn't always be defined subequently)
or at least, not one that a function should be returning.
so that it's defined for the call to ClassElementEvaluation
Every call to CreateDecoratorContextObject assumes that this parameter is there. (Of course, you'll need to add steps to *do* something with it.)
... to conform to what it accepts.
|
Thank you a ton for these fixes! Definitely helps a lot, I feel like I probably should have caught some of these but it's hard when you've been reading the same text over and over for days 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.