Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete EDAX symmetry aliases #537

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

hakonanes
Copy link
Member

Description of the change

Fixes #534.

Progress of the PR

Minimal example of the bug fix or new feature

>>> from orix import io
>>> xmap = io.load("Ti_single_crystal_scan.ang")
[/Users/hakon/kode/personal/orix/orix/io/plugins/ang.py:285](https://file+.vscode-resource.vscode-cdn.net/Users/hakon/kode/personal/orix/orix/io/plugins/ang.py:285): UserWarning: Number of columns, 13, in the file is not equal to the expected number of columns, [14, 10], for the 
assumed vendor 'tsl'. Will therefore assume the following columns: euler1, euler2, euler3, x, y, unknown1, unknown2, phase_id, unknown3, unknown4, etc.
  warnings.warn(
>>> print(xmap)
Phase    Orientations  Name  Space group  Point group  Proper point group     Color
    0  10324 (100.0%)    Ti         None          622                 622  tab:blue
Properties: unknown1, unknown2, unknown3, unknown4, unknown5, unknown6, unknown7
Scan unit: um

(Need to look at the header.)

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • Contributor(s) are listed correctly in __credits__ in orix/__init__.py and in
    .zenodo.json.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
…e descriptive

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes mentioned this pull request Dec 26, 2024
8 tasks
@hakonanes hakonanes changed the base branch from develop to main December 26, 2024 09:28
@hakonanes hakonanes changed the base branch from main to develop December 26, 2024 09:30
@hakonanes hakonanes changed the title 534 complete edax symmetry aliases Complete EDAX symmetry aliases Dec 30, 2024
@hakonanes hakonanes requested a review from CSSFrancis December 30, 2024 10:11
Copy link
Member

@CSSFrancis CSSFrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Simple enough change and tested.

@hakonanes hakonanes merged commit 9e7427d into pyxem:develop Dec 30, 2024
12 checks passed
@hakonanes hakonanes deleted the 534-complete-edax-symmetry-aliases branch December 30, 2024 15:32
@hakonanes
Copy link
Member Author

Thanks! I'll prepare a patch release for the new year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with loading HCP phase data from EDAX .ang files
2 participants