Fix index errors #84
Merged
Fix index errors #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happends for 0 vn or vt index
|
Hi @mlamarre thanks for the PR! Looks good to me. Can you add a test case to trigger these conditions? |
|
Yes, I'll try to find time to do this in the next couple of weeks. |
|
I added two minimal repro obj files with a text editor and two test cases. |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed errors on a specific file (can't share sorry) probably not following the standard but Meshlab can open the file that caused these two errors.
First IndexError, may be caused by a blank line after the last
vtSecond IndexError, may be caused by a zero (0) normal index in many faces even though there's a large number of
vnlines in that file.