Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to packaging #9

Merged
merged 2 commits into from
Jul 19, 2017
Merged

Switch to packaging #9

merged 2 commits into from
Jul 19, 2017

Conversation

jayfk
Copy link
Contributor

@jayfk jayfk commented Jul 18, 2017

closes #4.

@codecov
Copy link

codecov bot commented Jul 18, 2017

Codecov Report

Merging #9 into master will decrease coverage by 0.73%.
The diff coverage is 76.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   99.84%   99.11%   -0.74%     
==========================================
  Files          11       11              
  Lines         661      680      +19     
==========================================
+ Hits          660      674      +14     
- Misses          1        6       +5
Impacted Files Coverage Δ
dparse/parser.py 96.29% <76.19%> (-3.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6b3be7...02e5e84. Read the comment docs.

from . import filetypes


def parse_requirements(strs):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably get rid of this function by just checking for # and stripping it away.

@jayfk
Copy link
Contributor Author

jayfk commented Jul 18, 2017

According to pypa/packaging#102 the next (or the current?) release will drop support for Python 3.2 and 2.6.

Need to add some tests for that.

@jayfk jayfk merged commit f1131f2 into master Jul 19, 2017
@pombredanne pombredanne deleted the packaging-latest branch December 12, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove setuptools..
1 participant