-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deactivate mypy for _functional_pil.py
and video_reader.py
#8402
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8402
Note: Links to docs will display an error until the docs builds have been completed. ❌ 18 New Failures, 19 Unrelated FailuresAs of commit 0f399a7 with merge base 06ad737 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Static type checks on dynamically set attributes will always be a problem 😕
Hey @NicolasHug! You merged this PR, but no labels were added. |
…y` (#8402) Reviewed By: vmoens Differential Revision: D57099466 fbshipit-source-id: 9b0f8c4316c0cc4ad5220d408d060a40e4754792
Towards #8377
This PR deactivates mypy for
_functional_pil.py
because it started failing with PIL 10.3 with absurd errors like:which is not true, PIL.Image does have those attributes, they're just set dynamically at import time (thanks @pmeier for pointing that out!) https://github.com/python-pillow/Pillow/blob/58a47978af9f34851ce926303d05fa677010ce2a/src/PIL/Image.py#L203-L206
This also deactivates mypy for
video_reader
which is failing withThat module will be deprecated soon, so there's no point spending time on it.