Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ImageNet documentation #7503

Merged
merged 6 commits into from
Apr 14, 2023
Merged

Improve ImageNet documentation #7503

merged 6 commits into from
Apr 14, 2023

Conversation

puhuk
Copy link
Contributor

@puhuk puhuk commented Apr 7, 2023 •
edited by pytorch-bot bot
Loading

Update to download before using the ImageNet class.

cc @pmeier

@puhuk
Improve ImageNet documentation
2ab36c7 
Update to download before using the  `ImageNet` class.
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 7, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7503

Note: Links to docs will display an error until the docs builds have been completed.

❌ 25 Failures

As of commit 531fd0b:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@puhuk
Update imagenet.py
adde0b2 
Correct typo `2010` to `2012`
pmeier
pmeier reviewed Apr 12, 2023
View reviewed changes
@puhuk
Update imagenet.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
2d88d05
pmeier
pmeier approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @puhuk! One minor nit inline. Otherwise LGTM!

Rendered docs

NicolasHug
NicolasHug approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @puhuk

@NicolasHug NicolasHug merged commit fc377d0 into pytorch:main Apr 14, 2023
@pmeier pmeier mentioned this pull request Apr 14, 2023
Closed
facebook-github-bot pushed a commit that referenced this pull request Apr 24, 2023
@NicolasHug @facebook-github-bot
[fbsync] Improve ImageNet documentation (#7503)
262d336 
Summary:

Reviewed By: vmoens

Differential Revision: D45183666

fbshipit-source-id: b17f8b1c97ac766de2a441cb7c863980240397a7

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug

@pmeier pmeier

Assignees
No one assigned
Labels
cla signed enhancement module: datasets module: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@puhuk @NicolasHug @pmeier @facebook-github-bot