Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proto] Small optims for perspective bboxes op #6891

Merged
merged 14 commits into from
Nov 3, 2022
Merged

[proto] Small optims for perspective bboxes op #6891

merged 14 commits into from
Nov 3, 2022
+12 −11

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Nov 2, 2022 •
edited by pytorch-bot bot
Loading 

[----------- perspective_bounding_box cpu BoundingBoxFormat.XYXY ------------]
            |  perspective_bounding_box_old v2  |  perspective_bounding_box v2
1 threads: -------------------------------------------------------------------
      (4,)  |                100                |              100            
6 threads: -------------------------------------------------------------------
      (4,)  |                100                |              100            

Times are in microseconds (us).

[----------- perspective_bounding_box cpu BoundingBoxFormat.XYWH ------------]
            |  perspective_bounding_box_old v2  |  perspective_bounding_box v2
1 threads: -------------------------------------------------------------------
      (4,)  |                190                |              180            
6 threads: -------------------------------------------------------------------
      (4,)  |                210                |              190            

Times are in microseconds (us).

[---------- perspective_bounding_box cpu BoundingBoxFormat.CXCYWH -----------]
            |  perspective_bounding_box_old v2  |  perspective_bounding_box v2
1 threads: -------------------------------------------------------------------
      (4,)  |                240                |              231            
6 threads: -------------------------------------------------------------------
      (4,)  |                261                |              247            

Times are in microseconds (us).

[----------- perspective_bounding_box cuda BoundingBoxFormat.XYXY -----------]
            |  perspective_bounding_box_old v2  |  perspective_bounding_box v2
1 threads: -------------------------------------------------------------------
      (4,)  |                284                |              200            
6 threads: -------------------------------------------------------------------
      (4,)  |                300                |              200            

Times are in microseconds (us).

[----------- perspective_bounding_box cuda BoundingBoxFormat.XYWH -----------]
            |  perspective_bounding_box_old v2  |  perspective_bounding_box v2
1 threads: -------------------------------------------------------------------
      (4,)  |                400                |              300            
6 threads: -------------------------------------------------------------------
      (4,)  |                400                |              300            

Times are in microseconds (us).

[---------- perspective_bounding_box cuda BoundingBoxFormat.CXCYWH ----------]
            |  perspective_bounding_box_old v2  |  perspective_bounding_box v2
1 threads: -------------------------------------------------------------------
      (4,)  |                500                |              400            
6 threads: -------------------------------------------------------------------
      (4,)  |                500                |              400            

Times are in microseconds (us).

cc @datumbox @bjuncek @pmeier

@vfdev-5 vfdev-5 changed the title Proto update perspective bboxes [proto] Small optims for perspective bboxes op Nov 2, 2022
@vfdev-5 vfdev-5 added module: transforms Perf For performance improvements prototype labels Nov 2, 2022
datumbox
datumbox approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Feel free to merge on green CI.

@pmeier pmeier mentioned this pull request Nov 3, 2022
Merged
@vfdev-5 vfdev-5 merged commit 1502ed9 into pytorch:main Nov 3, 2022
@vfdev-5 vfdev-5 deleted the proto-update-perspective-bboxes branch November 3, 2022 11:34
facebook-github-bot pushed a commit that referenced this pull request Nov 4, 2022
@NicolasHug @facebook-github-bot
[fbsync] [proto] Small optims for perspective bboxes op (#6891)
0a65539 
Summary:
* [proto] Speed-up crop on bboxes and tests

* Fix linter

* Update _geometry.py

* Fixed device issue

* Revert changes in test/prototype_transforms_kernel_infos.py

* Fixed failing correctness tests

* [proto] Optimized functional pad op for bboxes + tests

* Renamed copy-pasted variable name

* [proto] Small optims for perspective bboxes op

Reviewed By: datumbox

Differential Revision: D41020554

fbshipit-source-id: b56eb6fda83713649e9f41f324dcf690742eba6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox

Assignees
No one assigned
Labels
cla signed module: transforms Perf For performance improvements prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vfdev-5 @datumbox @facebook-github-bot