Fix fill in rotate

[pmeier]

Fixes #1759

ToDo:

• documentation
• more / all image modes to NUM_BANDS dict
• compatibility fix for pillow<5.0.0
• test

[fmassa]

Hi,

Thanks for the PR!

I'm unsure about the fix. Isn't this just that the user who reported the problem had an old PIL version, that didn't support fillcolor?

EDIT: oh just saw your comment in #1759, ok now I understand

[pmeier]

@fmassa How do you want to test this? Simply call rotate with images of different modes and see if it does not raise an error?

[codecov-io]

Codecov Report

Merging #1760 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1760      +/-   ##
=========================================
- Coverage    0.28%   0.28%   -0.01%     
=========================================
  Files          92      92              
  Lines        7349    7355       +6     
  Branches     1108    1109       +1     
=========================================
  Hits           21      21              
- Misses       7320    7326       +6     
  Partials        8       8

Impacted Files	Coverage Δ
torchvision/transforms/functional.py	0% <0%> (ø)	⬆️
torchvision/models/detection/mask_rcnn.py	0% <0%> (ø)	⬆️
torchvision/models/detection/faster_rcnn.py	0% <0%> (ø)	⬆️
torchvision/models/detection/keypoint_rcnn.py	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add2ecc...f342088. Read the comment docs.

[fmassa]

Thanks a lot for the PR!

For the tests, let's create different images (with Image.fromarray for example) of different types and check that rotate with fill works. We can also have a simple test that rotate an image by 45 degrees, and verify that the filled value for the (0, 0) pixel is the one we specified.

[pmeier]

For the tests, let's create different images (with Image.fromarray for example) of different types and check that rotate with fill works.

As in smoke test or actually compare the result to something?

[fmassa]

This looks great, thanks a lot Philip!