Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split of "[TorchRec][PT2] KJT custom op for 1d lengths input" (#2163) #2176

Closed
wants to merge 1 commit into from

Conversation

TroyGarden
Copy link
Contributor

Summary:

X-link: pytorch/FBGEMM#2774

context

  • move the tensor.view(-1, stride) from python into the operator (c++)
  • make the PT2 complier happy
  • reference: D58948987

notes

  • not sure if we should directly change the op call in the jagged_tensor
  • tested on CPU and GPU
  • backward/autograd not tested

Differential Revision: D59031938

…h#2163)

Summary:
Pull Request resolved: pytorch#2163

X-link: pytorch/FBGEMM#2774

# context
* move the `tensor.view(-1, stride)` from python into the operator (c++)
* make the PT2 complier happy
* reference: D58948987

# notes
* not sure if we should directly change the op call in the jagged_tensor
* tested on CPU and GPU
* backward/autograd not tested

Differential Revision: D59031938
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59031938

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by b8a1c40.

@TroyGarden TroyGarden deleted the export-D59031938 branch August 8, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Reverted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants