Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI arg handling #488

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

GregoryComer
Copy link
Member

Fixes #468 and #466. Updates named arguments to be registered on subparsers, which allows removal of the arg re-ordering code.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 26, 2024
@GregoryComer GregoryComer force-pushed the update-cli-arg-handling branch from 52c3d91 to ffa9b73 Compare April 26, 2024 04:48
@GregoryComer GregoryComer changed the title Update CLI arg handling Update CLI arg handling (WIP) Apr 26, 2024
@GregoryComer GregoryComer force-pushed the update-cli-arg-handling branch from ffa9b73 to 8f92fa3 Compare April 26, 2024 05:17
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix

@malfet malfet merged commit 4c8af9b into pytorch:main Apr 26, 2024
22 of 26 checks passed
@GregoryComer GregoryComer changed the title Update CLI arg handling (WIP) Update CLI arg handling Apr 26, 2024
malfet pushed a commit that referenced this pull request Jul 17, 2024
Fixes #468 and #466. Updates named arguments to be registered on subparsers, which allows removal of the arg re-ordering code.
malfet pushed a commit that referenced this pull request Jul 17, 2024
Fixes #468 and #466. Updates named arguments to be registered on subparsers, which allows removal of the arg re-ordering code.
malfet pushed a commit that referenced this pull request Jul 17, 2024
Fixes #468 and #466. Updates named arguments to be registered on subparsers, which allows removal of the arg re-ordering code.
malfet pushed a commit that referenced this pull request Jul 17, 2024
Fixes #468 and #466. Updates named arguments to be registered on subparsers, which allows removal of the arg re-ordering code.
malfet pushed a commit that referenced this pull request Jul 17, 2024
Fixes #468 and #466. Updates named arguments to be registered on subparsers, which allows removal of the arg re-ordering code.
malfet pushed a commit that referenced this pull request Jul 17, 2024
Fixes #468 and #466. Updates named arguments to be registered on subparsers, which allows removal of the arg re-ordering code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arg parser doesn't work in a lot of situations
3 participants