Redirect website to real root domain #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For "reasons", we don't actually have a CNAME set up in GitHub. The result is that GitHub doesn't know that pytorch.org/captum should actually redirect to captum.ai. This change puts a bit of JS on every page in prod that will do that redirect. We should fix it properly but at least we'll have something in place.
zpao
added a commit
to zpao/botorch
that referenced
this pull request
Oct 30, 2019
zpao
added a commit
to zpao/botorch
that referenced
this pull request
Oct 30, 2019
|
FYI: don't forget to rebuild & deploy the website to pick this up (generally should treat that gh-pages branch as a build artifact, I won't send any PRs against it) |
|
Looking to have automatic deploys to captum.ai from master, but running into some snags at https://circleci.com/gh/pytorch/captum/1867 cc'ed @jlin27 and @JoelMarcey on this, since I'm not sure what we need to setup in CircleCI to have |
|
I think we are on our way to solving this - might have been a misnamed env variable in the config. |
facebook-github-bot
pushed a commit
to pytorch/botorch
that referenced
this pull request
Nov 1, 2019
Summary: Same as pytorch/captum#146 Fixes #300 Pull Request resolved: #306 Reviewed By: Balandat Differential Revision: D18231026 Pulled By: Jakepodell fbshipit-source-id: d93a2e1f82c87b6b79fbfc17fe3fbc78c4229679
NarineK
pushed a commit
to NarineK/captum-1
that referenced
this pull request
Nov 19, 2020
Redirect website to real root domain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For "reasons", we don't actually have a CNAME set up in GitHub. The
result is that GitHub doesn't know that pytorch.org/captum should
actually redirect to captum.ai. This change puts a bit of JS on every
page in prod that will do that redirect. We should fix it properly but
at least we'll have something in place.