Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sparse test collection warning #489

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Jul 9, 2024

Renamed the model from TestModel to ToyModel this is because pytest will by default try to collect any classes that start with the name Test

So this removes this warning

  test/sparsity/test_fast_sparse_training.py:17
    /pytorch/ao/test/sparsity/test_fast_sparse_training.py:17: PytestCollectionWarning: cannot collect test class 'TestModel' because it has a __init__ constructor (from: test/sparsity/test_fast_sparse_training.py)
      class TestModel(nn.Module):

Copy link

pytorch-bot bot commented Jul 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/489

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5c384b4 with merge base 12ac498 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 9, 2024
@msaroufim msaroufim requested a review from jcaip July 9, 2024 00:41
@msaroufim msaroufim changed the title msaroufim/removesparsewarn Remove sparse test collection warning Jul 9, 2024
@msaroufim msaroufim requested a review from jerryzh168 July 9, 2024 01:20
@jerryzh168 jerryzh168 merged commit e9d99ae into main Jul 9, 2024
13 checks passed
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
* push

* remove sparse test warning

* push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants