[flake8] Disable Y065 for now #11672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unblocks PyCQA/flake8-pyi#475
AlexWaygood
reviewed
Mar 30, 2024
| @@ -13,7 +13,8 @@ per-file-ignores = | |||
| # Y023: Alias typing as typing_extensions | |||
| # Y026: Have implicit type aliases | |||
| # Y053: have literals >50 characters long | |||
| *_pb2.pyi: Y021, Y023, Y026, Y053 | |||
| # Y065: TODO: Remove bare Incompletes | |||
| *_pb2.pyi: Y021, Y023, Y026, Y053, Y065 | |||
There was a problem hiding this comment.
This only ignores Y065 for files ending in _pb2.pyi
There was a problem hiding this comment.
That happens when editing too many branches at the same time ...
|
FWIW, I think we can just merge PyCQA/flake8-pyi#475 without this change (CI isn't failing on the PR, and we know why there's a big diff). We can easily add the Y065 ignore at the same time as bumping our flake8-pyi pin at typeshed |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Sure, let's do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unblocks PyCQA/flake8-pyi#475