Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix openpyxl worksheet columns to return tuple[Cell, ...] #10745

Closed
wants to merge 1 commit into from
Closed

fix openpyxl worksheet columns to return tuple[Cell, ...] #10745

wants to merge 1 commit into from

Conversation

ostr00000
Copy link

Fix for incorrect return type for property columns in Worksheet in openpyxl.

closes #10744

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@Avasam Avasam mentioned this pull request Sep 28, 2023
Merged
@srittau
Copy link
Collaborator

srittau commented Oct 4, 2023

Thanks for your contribution, @ostr00000 and sorry that it took so long. I've now merged @Avasam's big PR, which includes your change.

@ostr00000 ostr00000 deleted the openpyxl_column branch October 4, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openpyxl Worksheet columns is incorrectly typed
2 participants
@ostr00000 @srittau