Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out why CODEOWNERS is not working #1920

Closed
brettcannon opened this issue Apr 12, 2021 · 2 comments · Fixed by #1925
Closed

Figure out why CODEOWNERS is not working #1920

brettcannon opened this issue Apr 12, 2021 · 2 comments · Fixed by #1925
Assignees
Labels

Comments

@brettcannon
Copy link
Member

E.g. #1918 should have been assigned to Mark. And every PR should be assigned to someone thanks to our wildcard.

Probably need to bisect the file by commenting out lines to see if there's some specific section that isn't working (e.g. a bad username is breaking the whole file).

@JelleZijlstra
Copy link
Member

There might be a few issues:

    [err] line ...: User "@..." is not a member of the organization

Which is weird, since those people should definitely be in the Python org. Maybe it's just because I didn't give this tool my GitHub token and some of these people show up in https://github.com/orgs/python/people?query= as "private" for some reason.

  • Another run found:
    [err] line 252: "pep0418/" does not match any files in repository

@JelleZijlstra
Copy link
Member

I believe #1925 fixes it.

I'm worried about this breaking again silently in the future. If we ever remove a directory mentioned in CODEOWNERS, or (I believe) if anyone mentioned there leaves the python org, the file will silently stop working. It might be worth adding the GitHub action from the validator tool linked above to make sure the file remains valid. It would be good if GitHub provided some feedback directly if the file is invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants