Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes protocols with untyped slots #9314

Merged
merged 6 commits into from
Aug 28, 2020
Merged

Fixes protocols with untyped slots #9314

merged 6 commits into from
Aug 28, 2020

Conversation

sobolevn
Copy link
Member

Closes #7290

hauntsaninja
hauntsaninja reviewed Aug 16, 2020
View reviewed changes
sobolevn and others added 3 commits August 17, 2020 15:05
@sobolevn @hauntsaninja
Update mypy/semanal.py
66d7637 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@sobolevn
Update semanal.py
d01a56f
@sobolevn
Update semanal.py
d398a20
JukkaL
JukkaL approved these changes Aug 28, 2020
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR! This is a nice small improvement.

@JukkaL JukkaL merged commit 55cffc1 into python:master Aug 28, 2020
@sobolevn sobolevn deleted the issue-7290 branch August 28, 2020 17:31
This was referenced Jan 2, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protocol requires __slots__ to be explicitly typed
3 participants
@sobolevn @JukkaL @hauntsaninja