Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement get on out of order container proxy #81

Conversation

mbelang
Copy link

@mbelang mbelang commented Feb 29, 2020

fixes: #80

@mbelang
Copy link
Author

mbelang commented Feb 29, 2020

@sdispater please :)

@codecov-io
Copy link

codecov-io commented Feb 29, 2020

Codecov Report

Merging #81 into master will decrease coverage by 0.11%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   91.11%   90.99%   -0.12%     
==========================================
  Files          10       10              
  Lines        2206     2211       +5     
==========================================
+ Hits         2010     2012       +2     
- Misses        196      199       +3
Impacted Files Coverage Δ
tomlkit/container.py 84.24% <20%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bdaadc...d7abb80. Read the comment docs.

@mbelang mbelang closed this Feb 29, 2020
@mbelang mbelang deleted the fix/out-of-order-table-container-get branch February 29, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.get on class OutOfOrderTableProxy now always return None
2 participants