fix reduce_by_python_constraint for marker unions

[radoering]

E.g. if the python constraint is >=3.9, reducing python_version >= "3.8" or sys_platform == "linux" should be AnyMarker (not sys_platform == "linux").

Resolves: python-poetry/poetry#10239
Related-to: python-poetry/poetry#10237

• Added tests for changed code.
• Updated documentation for changed code.

Summary by Sourcery

Bug Fixes:

• Fixes an issue in reduce_by_python_constraint where marker unions were not correctly reduced when a python constraint was applied, resulting in incorrect marker evaluation.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes an issue in reduce_by_python_constraint where marker unions were not correctly reduced when the Python constraint allowed all Python versions specified in the union. The fix ensures that such markers are reduced to AnyMarker. Additionally, new test cases have been added to verify the corrected behavior.

Updated class diagram for Marker

classDiagram
    class Marker {
        +reduce_by_python_constraint(python_constraint: Constraint) Marker
    }
    Marker : Implements marker reduction logic
    note for Marker "Fixes an issue in `reduce_by_python_constraint` where marker unions were not correctly reduced when the Python constraint allowed all Python versions specified in the union."

Loading

File-Level Changes

Change	Details	Files
Improved the reduce_by_python_constraint function to correctly handle marker unions, ensuring that when the Python constraint allows all Python versions specified in the union, the entire marker is reduced to AnyMarker.	Modified the reduce_by_python_constraint function to return AnyMarker when the Python constraint allows all Python versions specified in a marker union. Removed unnecessary conditional logic that preserved other markers when the Python constraint allowed all Python versions in the union.	src/poetry/core/version/markers.py
Added new test cases to verify the correct behavior of reduce_by_python_constraint with marker unions and Python version constraints.	Added test cases to cover scenarios where a marker union should be reduced to an empty marker based on the Python constraint. Added test cases to cover scenarios where a marker union contains platform-specific conditions combined with Python version constraints.	tests/version/test_markers.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @radoering - I've reviewed your changes - here's some feedback:

Overall Comments:

• The change in test_only from 'python_version >= "3.8"', "~3.8", "" to 'python_version == "3.8"', "~3.8", "" seems incorrect.
• The logic in reduce_by_python_constraint could be simplified by returning AnyMarker() earlier if python_only_markers is empty.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[radoering]

I just changed this test because there is a duplicate of the original test some lines below.

[radoering]

I removed these test because with the fix they are not that intesting anymore because they are too similar to the test above.