simplify extra markers 2

[radoering]

Without this change the union of extra == "a" and extra == "c" and extra == "a" or extra == "b" is extra == "a" and extra == "c" or extra == "a" or extra == "b". With the change, it is simplified to extra == "a" or extra == "b".

Related to: python-poetry/poetry#10195

Similar to: #842

• Added tests for changed code.
• Updated documentation for changed code.

Summary by Sourcery

Tests:

• Add tests for the simplification of extra markers.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request simplifies the union of marker constraints, specifically addressing cases where combining an 'or' condition with an 'and' condition can be reduced to a simpler 'or' condition. This optimization avoids unnecessarily complex marker expressions.

Sequence diagram for union constraint simplification

sequenceDiagram
  participant UC as UnionConstraint
  participant MC as MultiConstraint

  UC->UC: union(other: MultiConstraint)
  alt any(c in other.constraints for c in self._constraints)
    UC-->UC: return self
  else
    UC->UC: new_constraints = [*self._constraints, other]
    UC-->UC: return new UnionConstraint(new_constraints)
  end

Loading

File-Level Changes

Change	Details	Files
Implements simplification logic for union constraints involving 'or' and 'and' conditions.	Adds a check within the union method of UnionConstraint to identify if any of the constraints in the UnionConstraint are present in the MultiConstraint. If a constraint from the UnionConstraint is found within the MultiConstraint, the method returns the original UnionConstraint, effectively simplifying the expression.	src/poetry/core/constraints/generic/union_constraint.py
Adds new test cases to verify the simplification of marker unions.	Adds test cases to test_markers.py to cover scenarios where the union of extra == "a" and extra == "c" and extra == "a" or extra == "b" should be simplified to extra == "a" or extra == "b". Adds a test case to test_constraint.py to cover scenarios where the union of extra1 or extra2 and extra1 and extra3 should be simplified to extra1 or extra2.	tests/version/test_markers.py tests/constraints/generic/test_constraint.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @radoering - I've reviewed your changes - here's some feedback:

Overall Comments:

• It might be helpful to add a comment explaining the logic behind the early return in union.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}