Use %d for year translations, convert to string for intcomma after
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a bug introduced in 3.14.0, where the format string was changed from %d to %s to add separators to the year. However, this needs to happen after translation because the translator uses the format strings as part of the translation. Closes python-humanize#21
|
Thanks for the fix! Please could you also add a test to |
|
Could you please assign me so I don't forget! Thanks! |
|
Done! Will set to draft as well. |
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 99.09% 99.11% +0.01%
==========================================
Files 9 9
Lines 666 678 +12
==========================================
+ Hits 660 672 +12
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Thank you! |
hugovk
changed the title
%d for year translations, convert to string for intcomma after
hugovk
changed the title
%d for year translations, convert to string for intcomma after%d for year translations, convert to string for intcomma after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug introduced in 3.14.0, where the format
string was changed from %d to %s to add separators to the year.
However, this needs to happen after translation because the
translator uses the format strings as part of the translation.
Closes #21