-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add same environments to Azure, except py37-freeze #4793
Add same environments to Azure, except py37-freeze #4793
Conversation
0ca54d8
to
0cca37e
Compare
Failing on two envs because apparently that Windows image does not contain the build tools for Python 2.7 (fails to build xfreeze and twisted). All other envs passed, the entire build took 17 minutes which, even we are missing PyPy, is very promising. |
Codecov Report
@@ Coverage Diff @@
## master #4793 +/- ##
==========================================
- Coverage 95.66% 95.64% -0.02%
==========================================
Files 113 113
Lines 25150 25151 +1
Branches 2498 2498
==========================================
- Hits 24059 24056 -3
- Misses 771 772 +1
- Partials 320 323 +3
Continue to review full report at Codecov.
|
I'm really excited about the timings we are getting:
And as of this writing both Travis and AppVeyor have not even started. 👍 |
d0ae803
to
21ed7b1
Compare
Nice. Would be good btw to not trigger AppVeyor/Travis from here. I'm not sure if they support "[skip …]" from the PR title, but then you could add it to commits, or manually cancel them after pushing. |
My bad, should have added |
572cc18
to
bc61974
Compare
Ready for review. Let's please squash all changes during merging. Only standing issue #4807 |
Nice, took 15 minutes, even faster than Travis. 👍 |
You have to force-push yourself.. but could be done after review / before merging. Is it meant to replace AppVeyor in the long run? |
Yep! So far it looks promising. Still need coverage though. |
py37-freeze will be tackled in pytest-dev#4807
5e9abd2
to
9cb504c
Compare
Rebased. 👍 |
Oh btw I meant in a future PR. I think we should merge this now and see if it behaves well over the next PRs (we of course can ignore it if it fails for weird reasons). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PyPy needs a little more work I suspect