Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add same environments to Azure, except py37-freeze #4793

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

nicoddemus
Copy link
Member

PyPy needs a little more work I suspect

@nicoddemus nicoddemus force-pushed the azure-include-more-envs branch from 0ca54d8 to 0cca37e Compare February 13, 2019 21:01
@nicoddemus
Copy link
Member Author

Failing on two envs because apparently that Windows image does not contain the build tools for Python 2.7 (fails to build xfreeze and twisted). All other envs passed, the entire build took 17 minutes which, even we are missing PyPy, is very promising.

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #4793 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4793      +/-   ##
==========================================
- Coverage   95.66%   95.64%   -0.02%     
==========================================
  Files         113      113              
  Lines       25150    25151       +1     
  Branches     2498     2498              
==========================================
- Hits        24059    24056       -3     
- Misses        771      772       +1     
- Partials      320      323       +3
Flag Coverage Δ
#docs 29.58% <ø> (ø) ⬆️
#doctesting 29.58% <ø> (ø) ⬆️
#linting 29.58% <ø> (ø) ⬆️
#linux 95.47% <0%> (-0.02%) ⬇️
#nobyte 92.2% <0%> (-0.01%) ⬇️
#numpy 92.99% <0%> (-0.02%) ⬇️
#pexpect 41.97% <ø> (ø) ⬆️
#pluggymaster 93.71% <0%> (-0.01%) ⬇️
#py27 93.67% <0%> (-0.02%) ⬇️
#py34 91.58% <0%> (-0.01%) ⬇️
#py35 91.61% <0%> (-0.01%) ⬇️
#py36 91.64% <0%> (-0.01%) ⬇️
#py37 93.81% <0%> (-0.01%) ⬇️
#trial 92.99% <0%> (-0.02%) ⬇️
#windows 93.67% <0%> (-0.02%) ⬇️
#xdist 93.69% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
testing/freeze/create_executable.py 0% <0%> (ø) ⬆️
src/_pytest/cacheprovider.py 95.75% <0%> (-1.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0a9f90...9cb504c. Read the comment docs.

@nicoddemus
Copy link
Member Author

nicoddemus commented Feb 15, 2019

I'm really excited about the timings we are getting:

Queued
37m ago
Started after 1m 57s in queue
35m ago
Completed after 15m 54s
19m ago

And as of this writing both Travis and AppVeyor have not even started. 👍

@nicoddemus nicoddemus force-pushed the azure-include-more-envs branch from d0ae803 to 21ed7b1 Compare February 15, 2019 17:56
@blueyed
Copy link
Contributor

blueyed commented Feb 15, 2019

Nice.

Would be good btw to not trigger AppVeyor/Travis from here.

I'm not sure if they support "[skip …]" from the PR title, but then you could add it to commits, or manually cancel them after pushing.

@nicoddemus
Copy link
Member Author

Would be good btw to not trigger AppVeyor/Travis from here.

My bad, should have added [skip travis] [skip appveyor] to the commits

@nicoddemus nicoddemus force-pushed the azure-include-more-envs branch 7 times, most recently from 572cc18 to bc61974 Compare February 18, 2019 18:01
@nicoddemus
Copy link
Member Author

Ready for review. Let's please squash all changes during merging.

Only standing issue #4807

@nicoddemus nicoddemus changed the title Add same environments to Azure, except PyPy Add same environments to Azure, except py37-freeze Feb 18, 2019
@nicoddemus
Copy link
Member Author

Nice, took 15 minutes, even faster than Travis. 👍

@blueyed
Copy link
Contributor

blueyed commented Feb 18, 2019

Let's please squash all changes during merging.

You have to force-push yourself.. but could be done after review / before merging.
Not time for it myself currently though.

Is it meant to replace AppVeyor in the long run?

@nicoddemus
Copy link
Member Author

Is it meant to replace AppVeyor in the long run?

Yep! So far it looks promising. Still need coverage though.

@nicoddemus nicoddemus force-pushed the azure-include-more-envs branch from 5e9abd2 to 9cb504c Compare February 18, 2019 20:24
@nicoddemus
Copy link
Member Author

Rebased. 👍

@nicoddemus
Copy link
Member Author

nicoddemus commented Feb 19, 2019

Yep! So far it looks promising. Still need coverage though.

Oh btw I meant in a future PR. I think we should merge this now and see if it behaves well over the next PRs (we of course can ignore it if it fails for weird reasons).

@nicoddemus
Copy link
Member Author

@blueyed @asottile, gentle ping. 👍

I'm anxious to see this live to see how it behaves on daily basis.

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit da30596 into pytest-dev:master Feb 21, 2019
@nicoddemus nicoddemus deleted the azure-include-more-envs branch February 22, 2019 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants