-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support xfailed and xpassed outcomes in RunResult. #3838
Conversation
the linting failed, please use |
Yeah, my bad, I disabled it because the pre-commit hardcodes Python 3.6 but I only have 2.7 and 3.7 installed. Will fix manually.. |
…esult.assert_outcomes`` signature.
1d3cb52
to
539a22c
Compare
@RonnyPfannschmidt rebased and linted |
@asottile im wondering, can pre-commit be taught to use something more controllable there? |
Upstream switched to just |
@asottile good point, what should pytest do, just the same? |
This should target (I want to take a good look at the code later, please don't merge yet 😁) |
@nicoddemus Yes, I guess you're right - I've just switched the base branch. |
Heh! 😁 |
Thanks @wimglenn! |
Added support for xfailed and xpassed outcomes to the
pytester.RunResult.assert_outcomes
signature.closes #3837