Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unescape to decodeURI #892

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

audibleptr
Copy link

This should be decodeURI(url.href), otherwise if %-encoded characters are present in the file path, they will get decoded to incorrect characters, resulting in errors like:

report.html:719 Uncaught DOMException: Failed to execute 'pushState' on 'History': A history state object with URL
'file:///home/user/%C3%90%C2%97%C3%90%C2%B0%C3%90%C2%B3%C3%91%C2%80%C3%91%C2%83%C3%90%C2%B7%C3%90%C2%BA%C3%90%C2%B8/report_x86_work/report.html?sort=result'
cannot be created in a document with origin 'null' and URL
'file:///home/user/%D0%97%D0%B0%D0%B3%D1%80%D1%83%D0%B7%D0%BA%D0%B8/report_x86_work/report.html'.

if file is located in a path with non-latin characters (note the different %-encoded strings), which results in no tests being shown in the report, just the counts.

Tested by manually changing this in a generated HTML, changing here because I'm relatively confident this will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant