-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: pyproject, pysat style updates #137
Conversation
if(pack_version.Version(pysat.__version__) | ||
> pack_version.Version('3.0.1')): | ||
load_kwargs['use_header'] = True | ||
load_kwargs['use_header'] = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend keeping the version test, but add a max version for this as well.
if all([Version(pysat.__version__) > Version('3.0.1'),
Version(pysat.__version__) < Version('3.2.0')]):
inst_kwargs['use_header'] = True
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the requirements files specifies a minimum of pysat 3.0.4, should we just proceed with the maximum cap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤒 excellent point
LOL, just remembered why I didn't merge this one last month. The new tests flag wasn't finalized. Incoming PR |
Description
Addresses #134, #131
NOTE: added backwards compat for pre-1.4 pandas for the operational server. pandas 1.1.5 is the maximum version supported there.
DOUBLE NOTE: The ICON TIEGCM feature is currently broken until pysatNASA 0.0.6 is released. Future fix in place with #132. This branch turns off testing temporarily until the next releases of pysat and pysatNASA are complete. TODO statements flag what needs to be updated. The pysatNASA cap of 0.0.4 is still required to trick the operational environment into behaving.
Uses the
_test_new_tests
instrument attribute to skip the multi-day tests for broken instruments, documented in #136. Implementation in pysat is in pysat/pysat#1166Type of change
How Has This Been Tested?
Tested against pysat 3.2.0 RC1 and pysat/pysat#1166
Test Configuration:
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release