ENH: add flow mode to COINS #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jGaboardi
reviewed
Jul 16, 2024
|
CI seems to be having a tough time resolving the environment in several cases. Maybe just a one-off fluke? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
=======================================
+ Coverage 97.4% 97.9% +0.5%
=======================================
Files 26 38 +12
Lines 4328 6244 +1916
=======================================
+ Hits 4214 6110 +1896
- Misses 114 134 +20
|
|
yeah, I wouldn't worry too much about that |
jGaboardi
approved these changes
Jul 16, 2024
|
If we don't care about the inability to resolve the windows environment, let's go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds flow mode of continuity which ensures that there's only a one stroke group per LineString and does not cause breakage when dealing with stroke attributes rather than stroke geometries.