Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: add type hints to the graph module #623

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

martinfleis
Copy link
Member

Closes #579

@martinfleis martinfleis requested a review from jGaboardi June 20, 2024 12:47
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.0%. Comparing base (4037c70) to head (2276317).
Report is 85 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #623     +/-   ##
=======================================
+ Coverage   97.4%   98.0%   +0.6%     
=======================================
  Files         26      38     +12     
  Lines       4328    6201   +1873     
=======================================
+ Hits        4214    6076   +1862     
- Misses       114     125     +11     
Files with missing lines Coverage Δ
momepy/graph.py 98.9% <100.0%> (+0.1%) ⬆️

@martinfleis martinfleis merged commit 4f81d91 into pysal:main Jun 20, 2024
15 checks passed
@martinfleis martinfleis deleted the graph-typing branch June 20, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: distinction between libpysal and networkx graphs
2 participants