-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linting & formatting for benchmarks/*
and docs/*
#578
Conversation
jGaboardi
commented
May 12, 2024
•
edited
Loading
edited
- This PR resolves more complete linting & formatting - docs & benchmarks #577
- big diff, but only linting & formatting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
=======================================
+ Coverage 97.4% 97.8% +0.4%
=======================================
Files 26 37 +11
Lines 4328 5160 +832
=======================================
+ Hits 4214 5045 +831
- Misses 114 115 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we set different line length for docs? Because using 88, some cells won't fit, like the first one after this section. I would like to avoid this in the documentation. It seems that the limit there is 80 characters.
Yes, seems like we can accomplish this with a subset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!